Conversation
|
I'd also provide more context and rationale when opening the PR to the real Compojre project. Input is welcome! |
liamchzh
force-pushed
the
compojure-full-route
branch
from
e8ff6e0 to
9e1744a
Compare
This provides access to the full route that contains the common prefix. The full-route info is added to the ':compojure/full-route' key in the request map. Co-authored-by: Liam Chen <liamchzh@gmail.com> Co-authored-by: Claire Alvis <claire.alvis@gmail.com>
liamchzh
force-pushed
the
compojure-full-route
branch
from
9e1744a to
014fedc
Compare
We use |
src/compojure/core.clj
Outdated
| (clout/route-compile (str route# ":__path-info") ~re-context) | ||
| (if (string? route#) | ||
| {:context-route route#} | ||
| {})))))) |
There was a problem hiding this comment.
in the PR, you should mention that the with-meta is our attempt to not change the type of make-context, as it is public (albeit not documented). we could make a more direct map-based implementation if backwards compatibility of make-context is not important
also not entirely sure what the full syntax is of context, so it's possible we're missing a case
emilywoods
left a comment
emilywoods
left a comment
There was a problem hiding this comment.
After talking through these changes, the pr looks good to me
This approach is simpler, pass the path down, rather than attaching it to the meta.
|
weavejester#212 has been merged! |
3 participants
This provides access to the full route that contains the common prefix.
The full-route info is added to the ':compojure/full-route' key in the
request map.